Not trigger search when touch on popup clickable components #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuuuube
added
kind/enhancement
jamesmaa
previously approved these changes
Sep 18, 2024
ext/js/language/text-scanner.js
Outdated
| */ | ||
| _createExcludeSelectorForPointerType(excludeSelector, pointerType) { | ||
| if (pointerType === 'touch') { | ||
| const extraSelector = '.gloss-link,.gloss-link *'; |
There was a problem hiding this comment.
Maybe add a comment here that says what this is trying to accomplish?
khaitruong922
changed the title
jamesmaa
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1418
Not sure if this is the cleanest solution, but the only way to know when to ignore the search on the
gloss-linkis to check iftouchpointer type triggers the search and add the exclude selectors.